Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flexoki theme #10002

Merged
merged 2 commits into from
Mar 31, 2024
Merged

add flexoki theme #10002

merged 2 commits into from
Mar 31, 2024

Conversation

ftqo
Copy link
Contributor

@ftqo ftqo commented Mar 25, 2024

Based on Flexoki
CleanShot 2024-03-25 at 12 51 25@2x

the-mikedavis
the-mikedavis previously approved these changes Mar 26, 2024
@gj1118
Copy link
Contributor

gj1118 commented Mar 26, 2024

@ftqo it seems that the rulers are not styled with appropriate colors. Should they be styled ?
I added the rulers= [80] in my config, and saw that they were being rendered in black.

@ftqo
Copy link
Contributor Author

ftqo commented Mar 26, 2024

@gj1118 Good catch! I'm not a user of rulers, so I didn't notice that. How does it look now?

@gj1118
Copy link
Contributor

gj1118 commented Mar 27, 2024

@ftqo looks good. Please see the screenshot below
image

But I am facing another issue. The cursor color is (in insert mode ) "white" and it is painfully hard to figure out where it is . Are you also seeing the same issue ?

Thanks
Gagan

@ftqo
Copy link
Contributor Author

ftqo commented Mar 27, 2024

@gj1118 I'm not seeing what's wrong in the image, could you modify the theme and show me what you would expect instead?

@gj1118
Copy link
Contributor

gj1118 commented Mar 27, 2024

@gj1118 I'm not seeing what's wrong in the image, could you modify the theme and show me what you would expect instead?

image
If you notice that the cursor is white .. this is what I meant earlier.

Thanks

@ftqo
Copy link
Contributor Author

ftqo commented Mar 27, 2024

I am unable to replicate this. Could it be related to your terminal or terminal multiplexer?
CleanShot 2024-03-27 at 13 39 13@2x

@gj1118
Copy link
Contributor

gj1118 commented Mar 27, 2024

I am unable to replicate this. Could it be related to your terminal or terminal multiplexer? CleanShot 2024-03-27 at 13 39 13@2x

Could be. I am not sure.I will look into it more from my side. Thanks for looking into it. Much appreciated.

Thanks once again.

@ftqo ftqo requested a review from the-mikedavis March 27, 2024 19:18
@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 28, 2024
@atahrijouti
Copy link
Contributor

off topic, but what WM are you using on macOS?

@ftqo
Copy link
Contributor Author

ftqo commented Mar 31, 2024

@atahrijouti yabai

@pascalkuthe pascalkuthe merged commit 2f4572d into helix-editor:master Mar 31, 2024
6 checks passed
@MaxVerevkin
Copy link

The current buffer in the bufferline is not highlighted.

@ftqo ftqo deleted the flexoki branch April 1, 2024 17:46
@ftqo
Copy link
Contributor Author

ftqo commented Apr 1, 2024

@MaxVerevkin I don't use the bufferline, could you make a PR adding reasonable styles?

Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
* add flexoki theme

* change ruler color to bg-2
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* add flexoki theme

* change ruler color to bg-2
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* add flexoki theme

* change ruler color to bg-2
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
* add flexoki theme

* change ruler color to bg-2
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
* add flexoki theme

* change ruler color to bg-2
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
* add flexoki theme

* change ruler color to bg-2
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
* add flexoki theme

* change ruler color to bg-2
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* add flexoki theme

* change ruler color to bg-2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants