Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a serializer for the jump alphabet config option #10156

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add a serializer for the jump alphabet config option #10156

merged 1 commit into from
Apr 4, 2024

Conversation

the-mikedavis
Copy link
Member

Without a serializer, we drop the custom alphabet when making config modifications like with :set. For example before this commit, :set mouse false would reset a custom alphabet to the default.

Closes #10153

@the-mikedavis
Add a serializer for the jump alphabet config option
a1b4fd2 
Without a serializer, we drop the custom alphabet when making config
modifications like with `:set`. For example before this commit,
`:set mouse false` would reset a custom alphabet to the default.
@the-mikedavis the-mikedavis added C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 4, 2024
@the-mikedavis the-mikedavis added this to the 24.04 milestone Apr 4, 2024
@archseer archseer merged commit 1539312 into master Apr 4, 2024
6 checks passed
@archseer archseer deleted the jump-alphabet-serializer branch April 4, 2024 14:28
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@the-mikedavis @postsolar
Add a serializer for the jump alphabet config option (helix-editor#10156
4689d8a 
)

Without a serializer, we drop the custom alphabet when making config
modifications like with `:set`. For example before this commit,
`:set mouse false` would reset a custom alphabet to the default.
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@the-mikedavis @mtoohey31
Add a serializer for the jump alphabet config option (helix-editor#10156
fcce59a 
)

Without a serializer, we drop the custom alphabet when making config
modifications like with `:set`. For example before this commit,
`:set mouse false` would reset a custom alphabet to the default.
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@the-mikedavis @Vulpesx
Add a serializer for the jump alphabet config option (helix-editor#10156
9b378af 
)

Without a serializer, we drop the custom alphabet when making config
modifications like with `:set`. For example before this commit,
`:set mouse false` would reset a custom alphabet to the default.
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@the-mikedavis
Add a serializer for the jump alphabet config option (helix-editor#10156
781c6bb 
)

Without a serializer, we drop the custom alphabet when making config
modifications like with `:set`. For example before this commit,
`:set mouse false` would reset a custom alphabet to the default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C-bug Category: This is a bug S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
24.07
Development

Successfully merging this pull request may close these issues.

Forgets jump-label-alphabet setting after :set command
2 participants
@the-mikedavis @archseer