Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add: validation of bundled themes in build workflow #11627

Merged
merged 13 commits into from
Sep 28, 2024
Merged

Add: validation of bundled themes in build workflow #11627

merged 13 commits into from
Sep 28, 2024
+143 −61

Commits on Sep 3, 2024

  1. Add: xtask to check themes for validation warnings

    @sarsapar1lla
    sarsapar1lla committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8ff1e3a View commit details
    Browse the repository at this point in the history

  2. Update: tidied up runtime paths

    @sarsapar1lla
    sarsapar1lla committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    ce7875b View commit details
    Browse the repository at this point in the history

  3. Update: test build workflow

    @sarsapar1lla
    sarsapar1lla committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9ed491a View commit details
    Browse the repository at this point in the history

  4. Update: address clippy lints

    @sarsapar1lla
    sarsapar1lla committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    af5c69a View commit details
    Browse the repository at this point in the history

  5. Revert: only trigger workflow on push to master branch

    @sarsapar1lla
    sarsapar1lla committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    232f8e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Add: Theme::from_keys factory method to construct theme from Toml keys

    @sarsapar1lla
    sarsapar1lla committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    34c6a35 View commit details
    Browse the repository at this point in the history

  2. Update: returning validation failures in Loader.load method

    @sarsapar1lla
    sarsapar1lla committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    c5c19c2 View commit details
    Browse the repository at this point in the history

  3. Update: commented out invalid keys from affected themes

    @sarsapar1lla
    sarsapar1lla committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cf85c94 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Update: correct invalid keys so that valid styles still applied

    @sarsapar1lla
    sarsapar1lla committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    9071387 View commit details
    Browse the repository at this point in the history

  2. Update: include default and base16_default themes in check

    @sarsapar1lla
    sarsapar1lla committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e5070ad View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Update: renamed validation_failures to load_errors

    @sarsapar1lla
    sarsapar1lla committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    8daf3f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Update: introduce load_with_warnings helper function and centralise l… 

    …ogging of theme warnings
    @sarsapar1lla
    sarsapar1lla committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    664bfa2 View commit details
    Browse the repository at this point in the history

  2. Update: use consistent naming throughout

    @sarsapar1lla
    sarsapar1lla committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    010039f View commit details
    Browse the repository at this point in the history