Fix picker won't scroll down when it hits the bottom #1544

[hahanein]

This fixes #1544

[k2d222]

a / b * c vs a / (b * c).
try let offset = self.cursor / std::cmp::max(1, (rows as usize)) * (rows as usize);

[hahanein]

try let offset = self.cursor / std::cmp::max(1, (rows as usize)) * (rows as usize);

That would alter the result in cases in which rows <= 1

I'm assuming that's correct regardless because this state is not useful anyway?

Amended the change.

[k2d222]

looking back at the code, this would be my favourite solution:
let offset = self.cursor - (self.cursor % rows as usize);
Its also a bit clearer what it does in my opinion.

[hahanein]

Works for me 👍🏻

[k2d222]

Not for me haha :) sorry I didn't know the remainder operation also fails with 0. Third time's the charm ;)
self.cursor - (self.cursor % std::cmp::max(1, rows as usize));
of self.cursor / std::cmp::max(1, rows as usize) * (rows as usize)

[hahanein]

I quit (math) 👍🏻

[pickfire]

Nice, thanks for fixing the issue.

[pickfire]

I think the check is stuck or something, I don't see the approve and run button, maybe need to create a new pull request?