Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toggle_comments command on multiple selections #1882

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Fix toggle_comments command on multiple selections #1882

merged 1 commit into from
Apr 5, 2022

Conversation

danyspin97
Copy link
Contributor

No description provided.

@archseer
Copy link
Member

What's the issue / what does this fix?

@danyspin97
Copy link
Contributor Author

The toggle_comments function (called with C-c by default) only applies to the first selection (i.e. after pressing C multiple selections appears on the lines below). It was an index problem, the end index is not inclusive, therefore there is no need to add 1 when considering the next minimum start index.

@archseer archseer merged commit 6b80cb8 into helix-editor:master Apr 5, 2022
@the-mikedavis the-mikedavis mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danyspin97 @archseer