Added checkmarks to health.rs output, Resolves #1894 #1918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
reviewed
Apr 1, 2022
helix-term/src/health.rs
Outdated
| @@ -263,8 +263,8 @@ fn probe_treesitter_feature(lang: &str, feature: TsFeature) -> std::io::Result<( | |||
| let mut stdout = stdout.lock(); | |||
|
|
|||
| let found = match load_runtime_file(lang, feature.runtime_filename()).is_ok() { | |||
| true => "Found".green(), | |||
| false => "Not found".red(), | |||
| true => "Found ✓".green(), | |||
There was a problem hiding this comment.
We could replace the text with symbols altogether? \cc @sudormrfbin
There was a problem hiding this comment.
Added this change in commit 96a1027
There was a problem hiding this comment.
I thought just the symbol would make it look less readable, but it looks good 👍🏾
|
This doesn't address the actual issue in #1894 though, which was to add the checkmarks to the the LSP and DAP binary names (2nd and 3rd columns). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Highlight, Textobject and Indent columns, health.rs now additionally prints either ✓ or ✘. This is in response to Issue #1894