Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support insert register in prompt #2458

Merged
merged 8 commits into from
May 20, 2022
Merged

support insert register in prompt #2458

merged 8 commits into from
May 20, 2022

Conversation

QiBaobin
Copy link
Contributor

No description provided.

@QiBaobin
Copy link
Contributor Author

Just saw another PR #1924 for the same purpose, so follow the suggestion there to use a generic handler instead of adding a new flag.

@the-mikedavis the-mikedavis linked an issue May 11, 2022 that may be closed by this pull request
@QiBaobin
Copy link
Contributor Author

Screen Shot 2022-05-13 at 15 47 44

Co-authored-by: Ivan Tham <pickfire@riseup.net>
@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label May 18, 2022
@archseer archseer merged commit 6462542 into helix-editor:master May 20, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
* support insert register in prompt

* use next_char_handler instead of a flag

* Fix clippy issue

* show autoinfo when inserting register

* Revert "show autoinfo when inserting register"

This reverts commit 5488344.

* use completion instead of autoinfo

autoinfo is overlapped when using prompt

* recalculate_completion after inserting register

* Update helix-term/src/ui/prompt.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

Co-authored-by: Ivan Tham <pickfire@riseup.net>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
* support insert register in prompt

* use next_char_handler instead of a flag

* Fix clippy issue

* show autoinfo when inserting register

* Revert "show autoinfo when inserting register"

This reverts commit 5488344.

* use completion instead of autoinfo

autoinfo is overlapped when using prompt

* recalculate_completion after inserting register

* Update helix-term/src/ui/prompt.rs

Co-authored-by: Ivan Tham <pickfire@riseup.net>

Co-authored-by: Ivan Tham <pickfire@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow C-r to insert register contents in prompts and pickers
4 participants