Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme key to change highlight of selected line numbers #260

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

sudormrfbin
Copy link
Member

@sudormrfbin sudormrfbin commented Jun 14, 2021

Adds ui.linenr.selected which controls highlight of line numbers which have cursors on them. Selections are now rendered before the gutter to accommodate this change (is this important ?).

Screenshot_2021-06-14_20-01-14

TODO:

  • Update documentation
  • Change contrib/ theme files to include new key

@sudormrfbin sudormrfbin changed the title theme set current linenr Theme key to change highlight of selected line numbers Jun 14, 2021
helix-term/src/ui/editor.rs Outdated Show resolved Hide resolved
@sudormrfbin
Copy link
Member Author

Falls back to ui.linenr if ui.linenr.selected is not defined. Rebased, added docs and updated themes.

@sudormrfbin sudormrfbin force-pushed the theme-set-current-linenr branch 2 times, most recently from b2a0ee4 to b370bb9 Compare June 15, 2021 04:24
@pickfire pickfire added the A-theme Area: Theme and appearence related label Jun 15, 2021
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add the TODO and I think we are good. Not tested.

theme.toml Show resolved Hide resolved
Adds `ui.linenr.selected` which controls highlight of linu numbes which
have cursors on.

- Fallback to linenr if linenr.selected is missing

- Update docs and themes

- Add TODOs for themes with temporary linenr.selected
@sudormrfbin
Copy link
Member Author

Added the TODOs

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested and works.

@archseer archseer merged commit d1c8a74 into helix-editor:master Jun 16, 2021
@sudormrfbin sudormrfbin deleted the theme-set-current-linenr branch June 16, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants