Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elixir: inject Markdown into docs, remove h sigil HEEx injection #2619

Merged
merged 2 commits into from
May 31, 2022

Conversation

connorlay
Copy link
Contributor

@the-mikedavis I figured I'd checkout Helix and see how it compares to Neovim. Consider me a convert 😆

This PR contains two changes:

  • injects Markdown, the official documentation format, into Elixir
  • Removes the non-existent h sigil from Elixir language injections. Phoenix Live View only supports the uppercase H sigil for HEEx.

Please let me know if there are any tests or documentation that need to be updated. Thanks!

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah TIL HEEx is limited to ~H, that makes sense 😄

Glad we could steal you from nvim - welcome! 🥳

runtime/queries/elixir/injections.scm Outdated Show resolved Hide resolved
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@the-mikedavis the-mikedavis merged commit fc8c488 into helix-editor:master May 31, 2022
@the-mikedavis
Copy link
Member

W.r.t. tests, I think it might be good in the long-run to have highlight tests in the CI and/or cargo testsuite. For now I think it would be a little heavy since we're adding new languages very often and tree-sitter queries are already a lot to learn if you've never seen tree-sitter before

@archseer
Copy link
Member

Consider me a convert

I see our Helix evangelism strikeforce is just as strong as the Rust one :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants