Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] Nord Light #2908

Merged
merged 4 commits into from
Jul 1, 2022
Merged

[Theme] Nord Light #2908

merged 4 commits into from
Jul 1, 2022

Conversation

xcdkz
Copy link
Contributor

@xcdkz xcdkz commented Jun 28, 2022

Nord inspired light theme

Screenshot_20220629_012123

@xcdkz xcdkz changed the title Nord Light [Theme] Nord Light Jun 28, 2022
@archseer
Copy link
Member

Does this follow the palette guidelines? https://www.nordtheme.com/docs/colors-and-palettes

From what I can tell red & orange are intended to only be used for UI elements and warnings. Compare this to the VSCode version: https://vscode.dev/theme/huytd.nord-light/Nord%20Light

@xcdkz
Copy link
Contributor Author

xcdkz commented Jun 29, 2022

Does this follow the palette guidelines? https://www.nordtheme.com/docs/colors-and-palettes

From what I can tell red & orange are intended to only be used for UI elements and warnings. Compare this to the VSCode version: https://vscode.dev/theme/huytd.nord-light/Nord%20Light

Haven't seen that one. I actually used Doom Nord Light from Doom Emacs as a reference:
image

I'll try to work with these palette guidelines and show how it looks like then.

@xcdkz
Copy link
Contributor Author

xcdkz commented Jun 29, 2022

There's an updated version(cursorline doesn't work in the screenshot, but it's probably my fault). It's based on the guidelines mentioned above:
image
It definitely has way less contrast than the previous one

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely has way less contrast than the previous one

Yeah but it looks much more in-line with the nord-palette. Dark-mode nord is pretty low-contrast too. To me the doom version you linked looks uncharacteristically high contrast.

This is looking good to me now though 👍

@archseer archseer merged commit 444bc24 into helix-editor:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants