fix: error that caused usize to overflow #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
approved these changes
Jul 10, 2022
|
Thank you for reviewing😊 |
archseer
approved these changes
Jul 10, 2022
| @@ -1414,7 +1414,7 @@ fn copy_selection_on_line(cx: &mut Context, direction: Direction) { | |||
| let (head, anchor) = if range.anchor < range.head { | |||
| (range.head - 1, range.anchor) | |||
There was a problem hiding this comment.
Do we need this here too?
There was a problem hiding this comment.
I don't think it's possible for range.head to be 0 in this branch because of the if condition: range.anchor < range.head implies range.head is >= 1 unless it's a zero-width selection which should not be possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix this bug #2981