Fix different document panic #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would panic when given the view for the current document for a different document.
EricCrosson
added a commit
to EricCrosson/dotfiles
that referenced
this pull request
Jul 23, 2022
To bring in helix-editor/helix#3160
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
Would panic when given the view for the current document for a different document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3148
Would panic when given the view for the current document for a different document. This should fix the panic while keeping the jump history when splitting for the same file.