Fix tab highlight when tab is partially visible #3313
Conversation
Dealing with truncating is a mess, especially when it comes to wide unicode graphemes. This way it should work no matter what.
| let rect = Rect::new( | ||
| viewport.x as u16, | ||
| viewport.y + line, | ||
| (width - cut_off_start) as u16, | ||
| 1, | ||
| ); |
There was a problem hiding this comment.
Testing this out with something non-whitespace-like but multi-width like "😀", we render an empty space instead of any character (because of the rect here). I think that's a good choice but I wonder if there's anything better to signal that a multi-width character is getting chopped off here?
I would say … but then we're rendering something completely different than the actual source. Maybe the plain rect is the best choice? ¯\_(ツ)_/¯
There was a problem hiding this comment.
I considered rendering a character to indicate that a wide grapheme has been cut off, but I think keeping it simple and showing nothing is the right approach.
If we were to render a character it should probably be configurable which char to use, (like how it is with whitespace) but I think that's overkill.
* Fix tab highlight when tab is partially visible * Make it style based, and not truncation based Dealing with truncating is a mess, especially when it comes to wide unicode graphemes. This way it should work no matter what. * Inline style calculation into branches
Resolves #2992.
Works for tabs, as well as other wide graphemes such as
Ideographic Space " "