Split modification indicator from file statusline elements #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's call this "FileModificationIndicator" |
|
@the-mikedavis Ok, I found a reference to dirty somewhere so that's why I called it that. |
|
@the-mikedavis I changed it along with the other related variables. |
kirawi
added
A-gui
kirawi
added
R-breaking-change
|
@kirawi Is there anything you are waiting for me on this PR? |
the-mikedavis
added
S-waiting-on-review
|
@the-mikedavis I feel like this is a fairly uncontroversial change. |
|
@kirawi @the-mikedavis The tests are passing now. I didn't see that before. |
Closed
|
We could make the element customizable. |
the-mikedavis
approved these changes
Feb 10, 2023
the-mikedavis
changed the title
|
I believe this one needs an update in the configuration docs. |
|
Ah good catch, a new line for this should be added in this table helix/book/src/configuration.md Line 93 in 0a7c697 |
|
Created #6036 to update the docs. |
theteachr
added a commit
to theteachr/helix
that referenced
this pull request
Aug 14, 2023
Obsoleted by helix-editor#4731
Merged
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
Obsoleted by helix-editor#4731
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
Obsoleted by helix-editor#4731
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Obsoleted by helix-editor#4731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempts to close #4686
Adds a new "file-dirty" status line element that can replace the
[+]symbol that appears after the file name.This allows the element to be added before the "file-name" element so the dirty symbol will be visible for long file/directory names.
Adds logic to keep the dirty element after the "file-name" element if it is not in the list. This keeps current config files and the default configuration working as they were before while allowing the dirty element to be placed wherever the config file specifies.