feat(lsp): pass client_info on initialization #4904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirawi
added
A-language-server
helix-lsp/build.rs
Outdated
Comment on lines
7
to
17
| let git_hash = Command::new("git") | ||
| .args(["rev-parse", "HEAD"]) | ||
| .output() | ||
| .ok() | ||
| .filter(|output| output.status.success()) | ||
| .and_then(|x| String::from_utf8(x.stdout).ok()); | ||
|
|
||
| let version: Cow<_> = match git_hash { | ||
| Some(git_hash) => format!("{} ({})", VERSION, &git_hash[..8]).into(), | ||
| None => VERSION.into(), | ||
| }; |
There was a problem hiding this comment.
It's a small block to re-use but I wonder if it should be a constant in helix-loader so it can be re-used in helix-lsp and helix-term
There was a problem hiding this comment.
Done, also not sure if it maybe would be better to expose GIT_SHA on it's own.
There was a problem hiding this comment.
@the-mikedavis I tried it but it makes it very verbose in around the 3 call-sides we have. Until we have a use case for GIT_HASH on it's own I would keep it this way.
Pass client name ('helix') and client version (version / git hash)
to LSP server on initialization.
matoous
force-pushed
the
md/lsp-client-info
branch
from
e783c49
to
57aced2
Compare
the-mikedavis
approved these changes
Dec 9, 2022
herkhinah
pushed a commit
to herkhinah/helix
that referenced
this pull request
Dec 11, 2022
Pass client name ('helix') and client version (version / git hash)
to LSP server on initialization.
freqmod
pushed a commit
to freqmod/helix
that referenced
this pull request
Feb 8, 2023
Pass client name ('helix') and client version (version / git hash)
to LSP server on initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass client name ('helix') and client version (version / git hash) to LSP server on initialization.