Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(theme): adjust base16_transparent and dark_high_contrast #5105

Merged
merged 5 commits into from
Dec 11, 2022

Conversation

GreasySlug
Copy link
Contributor

  • Use underline instead of modifier = ["underlined"]
  • Add base theme author sign
  • Adjust some colors

base16_transparent

"diagnostic.debug" ={ fg ="gray", modifiers = ["underlined"] }
"diagnostic.warning" = { fg = "yellow", modifiers = ["underlined"] }
"diagnostic.error" = { fg ="light-red", modifiers = ["underlined"] }
"diagnostic.info" = { underline = { color = "light-blue", style = "dot" } }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the documentation is currently incorrect about this underline style, it should be dotted:

"dotted" => Ok(Self::Dotted),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think I mixed that up 😅 I think the documentation was what I originally planning. We use curl and line so using the passive dotted and dashed seemed inconsistent. Perhaps this should be changed to dashes and dots in both documentation and implementation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're ok as passive - it makes sense to me as "dotted line" or "dashed line". When in doubt I would say we should follow whatever kitty says they are but it looks like then we would need to change to "curly" too for consistency: https://sw.kovidgoyal.net/kitty/underlines/

I think that just updating the documentation to say "dotted" would be the best choice to minimize breaking changes

@pascalkuthe pascalkuthe added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 11, 2022
@GreasySlug
Copy link
Contributor Author

Also added dark_high_contrast

dark_high_contrast

@GreasySlug GreasySlug changed the title update(theme): ajust base16_transparent update(theme): ajust base16_transparent and dark_high_contrast Dec 11, 2022
@the-mikedavis the-mikedavis changed the title update(theme): ajust base16_transparent and dark_high_contrast update(theme): adjust base16_transparent and dark_high_contrast Dec 11, 2022
@the-mikedavis the-mikedavis merged commit c5bfb79 into helix-editor:master Dec 11, 2022
@GreasySlug GreasySlug deleted the theme branch April 4, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants