Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diagnostic indicator background for gruvbox themes #5540

Conversation

joshbainbridge
Copy link
Contributor

The diagnostic indicator background did not match the column or row's background colour as this was context specific, and the background for the indicator was being explicitly set.

This commit removes the explicit value for the indicators background allowing it to adapt to the context. This aligns it with other themes, and resolves the issue.

Before:
Screenshot 2023-01-15 at 13 10 49
After:
Screenshot 2023-01-15 at 13 11 05

The diagnostic indicator background did not match the column or rows background
colour as this was context specific, and the background for the indicator was
being explicitly set.

This commit removes the explicit value for the indicators background allowing
it to adapt to the context. This is aligns it with other themes, and resolves
the issue.
@the-mikedavis the-mikedavis merged commit b65f104 into helix-editor:master Jan 17, 2023
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
…5540)

The diagnostic indicator background did not match the column or rows background
colour as this was context specific, and the background for the indicator was
being explicitly set.

This commit removes the explicit value for the indicators background allowing
it to adapt to the context. This is aligns it with other themes, and resolves
the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants