Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queries/nix: add injections for builtins and writers #5629

Merged

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Jan 22, 2023

  • queries/nix: document existing injections subjects
  • queries/nix: add injection for writeCBin nixpkgs trivial builder
  • queries/nix: add injections for nix builtins
  • queries/nix: add injections for nixpkgs writers

@pacien pacien changed the title queries nix add builtins writers queries/nix: add injections for builtins and writers Jan 22, 2023
@pacien
Copy link
Contributor Author

pacien commented Jan 22, 2023

CC past file committers: @nrdxp, @the-mikedavis, @farwyler

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jan 22, 2023
Copy link
Contributor

@farwyler farwyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've tried these today and they work as expected. very helpful use of injections!
🙏🏻 thanks @pacien

runtime/queries/nix/injections.scm Outdated Show resolved Hide resolved
`writeC` without "Bin" has been removed from nixpkgs/**/trivial-builders.nix, but let's keep it for backwards compatibility.

Co-authored-by: farwyler <1705805+farwyler@users.noreply.github.com>
@the-mikedavis the-mikedavis merged commit 22b3d3d into helix-editor:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants