Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Containerfile file-type for dockerfile language #5873

Merged

Conversation

TheAlgorythm
Copy link
Contributor

The Containerfile is a vendor independent name for the Dockerfile when using things like podman. It has the same syntax and therefore it is possible to extend the file-types.
But I am not sure whether it would be better to define a different language with the same parameters. It would better show being vendor independent but also a bit more bloat.
Further I am not sure why there is a lowercase dockerfile in the file-types and if it is also needed for the Containerfile.

@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Feb 7, 2023
@the-mikedavis the-mikedavis changed the title [A-language-support] add Containerfile language Add Containerfile file-type for dockerfile language Feb 7, 2023
@the-mikedavis
Copy link
Member

.dockerfile is a less common file extension for dockerfiles, for example build.dockerfile. It looks like .containerfile is used by some projects (see https://github.com/search?q=path%3A*.containerfile&type=code) so it probably makes sense to add it here as well

@TheAlgorythm
Copy link
Contributor Author

In my experience this file extension always started uppercase but adding the lowercase one shouldn't hurt. So I did add it.

@the-mikedavis the-mikedavis merged commit 882fa11 into helix-editor:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-language-support Area: Support for programming/text languages S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants