Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved yuck highlighting (and parser), and introduced a tag.builtin scope #6242

Merged
merged 4 commits into from
Mar 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions book/src/themes.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ We use a similar set of scopes as
- `special` (preprocessor in C)

- `tag` - Tags (e.g. `<body>` in HTML)
- `builtin`

- `namespace`

Expand Down
2 changes: 1 addition & 1 deletion languages.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2206,7 +2206,7 @@ indent = { tab-width = 2, unit = " " }

[[grammar]]
name = "yuck"
source = { git = "https://github.com/Philipp-M/tree-sitter-yuck", rev = "9e97da5773f82123a8c8cccf8f7e795d140ed7d1" }
source = { git = "https://github.com/Philipp-M/tree-sitter-yuck", rev = "e3d91a3c65decdea467adebe4127b8366fa47919" }

[[language]]
name = "prql"
Expand Down
135 changes: 88 additions & 47 deletions runtime/queries/yuck/highlights.scm
Original file line number Diff line number Diff line change
@@ -1,66 +1,107 @@
; Errors

(ERROR) @error

(line_comment) @comment
; Comments

; keywords and symbols
(comment) @comment

(keyword) @keyword
(symbol) @tag
; Operators

; literals
[
"+"
"-"
"*"
"/"
"%"
"||"
"&&"
"=="
"!="
"=~"
">"
"<"
">="
"<="
"!"
"?."
"?:"
] @operator

(bool_literal) @constant.builtin.boolean
(num_literal) @constant.numeric
(ternary_expression
["?" ":"] @operator)

; strings
(string_interpolation
(string_interpolation_start) @punctuation.special
(string_interpolation_end) @punctuation.special)
; Punctuation

[ ":" "." "," ] @punctuation.delimiter

[ "{" "}" "[" "]" "(" ")" ] @punctuation.bracket

; Literals

(number (float)) @constant.numeric.float

(number (integer)) @constant.numeric.integer

(boolean) @constant.builtin.boolean

; Strings

(escape_sequence) @constant.character.escape

(string
[
(unescaped_single_quote_string_fragment)
(unescaped_double_quote_string_fragment)
(unescaped_backtick_string_fragment)
"\""
"'"
"`"
]) @string
(string_interpolation
"${" @punctuation.special
"}" @punctuation.special)

; operators and general punctuation
[ (string_fragment) "\"" "'" "`" ] @string

(unary_expression
operator: _ @operator)
; Attributes & Fields

(binary_expression
operator: _ @operator)
(keyword) @attribute

(ternary_expression
operator: _ @operator)
; Functions

[
":"
"."
","
] @punctuation.delimiter
(function_call
name: (ident) @function)

[
"("
")"
"["
"]"
"{"
"}"
] @punctuation.bracket
[
":"
"."
","
] @punctuation.delimiter
; Variables

; Rest (general identifiers that are not yet catched)
(ident) @variable

(array
(symbol) @variable)

; Builtin widgets

(list .
((symbol) @tag.builtin
(#match? @tag.builtin "^(box|button|calendar|centerbox|checkbox|circular-progress|color-button|color-chooser|combo-box-text|eventbox|expander|graph|image|input|label|literal|overlay|progress|revealer|scale|scroll|transform)$")))

; Keywords

; I think there's a bug in tree-sitter the anchor doesn't seem to be working, see
; https://github.com/tree-sitter/tree-sitter/pull/2107
(list .
((symbol) @keyword
(#match? @keyword "^(defwindow|defwidget|defvar|defpoll|deflisten|geometry|children|struts)$")))

(list .
((symbol) @keyword.control.import
(#eq? @keyword.control.import "include")))

; Loop

(loop_widget . "for" @keyword.control.repeat . (symbol) @variable . "in" @keyword.operator . (symbol) @variable)

(loop_widget . "for" @keyword.control.repeat . (symbol) @variable . "in" @keyword.operator)

; Tags

; TODO apply to every symbol in list? I think it should probably only be applied to the first child of the list
(list
(symbol) @tag)

; Other stuff that has not been catched by the previous queries yet

(index) @variable
(ident) @variable
(index) @variable
2 changes: 1 addition & 1 deletion runtime/queries/yuck/injections.scm
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
((line_comment) @injection.content
((comment) @injection.content
(#set! injection.language "comment"))