Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure :toggle soft-wrap.enable works by default #6742

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

pascalkuthe
Copy link
Member

@pascalkuthe pascalkuthe commented Apr 13, 2023

Fixes #6605

As described in #6656 (comment) the correct fix here was simply to default to Some(false) for the global config (instead of None which lead to the same behaviour but caused issues with :toggle) while continuing to default to None for the language config so that the fallback keeps working correctly.

@pascalkuthe pascalkuthe added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. labels Apr 13, 2023
@pascalkuthe pascalkuthe added this to the 23.03.1 milestone Apr 13, 2023
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@the-mikedavis the-mikedavis merged commit 5ec4119 into master Apr 13, 2023
@the-mikedavis the-mikedavis deleted the softwrap_toggle branch April 13, 2023 18:37
@gibbz00
Copy link
Contributor

gibbz00 commented Apr 14, 2023

Awesome, apologies for the unsound PR 🙈

Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Soft-wrap enable toggle does not work.
4 participants