Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Odin grammar to ap29600/tree-sitter-odin #6766

Merged
merged 8 commits into from
Apr 27, 2023

Conversation

ap29600
Copy link
Contributor

@ap29600 ap29600 commented Apr 15, 2023

The previously adopted grammar, MineBill/tree-sitter-odin, is unmaintained and mentions my repository as an alternative source.

ap29600 and others added 2 commits April 15, 2023 14:22
The previously adopted grammar, `MineBill/tree-sitter-odin`, is unmaintained and mentions my repository as an alternative source.
@ap29600
Copy link
Contributor Author

ap29600 commented Apr 15, 2023

I noticed the CI was failing because I forgot to update the queries folder, sorry!

@the-mikedavis the-mikedavis self-requested a review April 15, 2023 15:02
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the highlights and indents copied over from the new repository? They are in neovim format and need the captures adjusted to the ones Helix uses (https://docs.helix-editor.com/master/themes.html#syntax-highlighting) and the indents should use the Helix style for indentation https://docs.helix-editor.com/master/guides/indent.html

@ap29600
Copy link
Contributor Author

ap29600 commented Apr 17, 2023

thank you, I updated those. I didn't realize the format of the queries was editor-specific.

runtime/queries/odin/highlights.scm Outdated Show resolved Hide resolved
runtime/queries/odin/highlights.scm Outdated Show resolved Hide resolved
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@pascalkuthe pascalkuthe merged commit 9cdc6b2 into helix-editor:master Apr 27, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
* Change Odin grammar to `ap29600/tree-sitter-odin`

The previously adopted grammar, `MineBill/tree-sitter-odin`, is unmaintained and mentions my repository as an alternative source.

* update queries

* docgen

* fix queries

* Update runtime/queries/odin/highlights.scm

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* remove `ERROR` query for `odin`

* track the latest rev in `ap29600/tree-sitter-odin`

* runtime/queries/odin/highlights.scm: update rune highlight class

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

---------

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
* Change Odin grammar to `ap29600/tree-sitter-odin`

The previously adopted grammar, `MineBill/tree-sitter-odin`, is unmaintained and mentions my repository as an alternative source.

* update queries

* docgen

* fix queries

* Update runtime/queries/odin/highlights.scm

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* remove `ERROR` query for `odin`

* track the latest rev in `ap29600/tree-sitter-odin`

* runtime/queries/odin/highlights.scm: update rune highlight class

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

---------

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Change Odin grammar to `ap29600/tree-sitter-odin`

The previously adopted grammar, `MineBill/tree-sitter-odin`, is unmaintained and mentions my repository as an alternative source.

* update queries

* docgen

* fix queries

* Update runtime/queries/odin/highlights.scm

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

* remove `ERROR` query for `odin`

* track the latest rev in `ap29600/tree-sitter-odin`

* runtime/queries/odin/highlights.scm: update rune highlight class

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>

---------

Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants