-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language support for persistent library syntax #7261
Merged
pascalkuthe
merged 6 commits into
helix-editor:master
from
lykahb:lykahb/add-haskell-persistent-language
Jul 9, 2023
Merged
Add language support for persistent library syntax #7261
pascalkuthe
merged 6 commits into
helix-editor:master
from
lykahb:lykahb/add-haskell-persistent-language
Jul 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also tried an alternative recognition of the injected language that moves the recognition from injection-regex into the haskell injection query. Let me know which variant you consider cleaner. ; haskell/injections.scm
((comment) @injection.content
(#set! injection.language "comment"))
(quasiquote
(quoter) @_quoter
((quasiquote_body) @injection.content
(#match? @_quoter "(persistWith|persistLowerCase|persistUpperCase)")
(#set! injection.language "haskell-persistent" )
)
)
(quasiquote
(quoter) @injection.language
(quasiquote_body) @injection.content) # languages.toml
[[language]]
name = "haskell-persistent"
scope = "source.persistentmodels"
injection-regex = "haskell-persistent"
file-types = ["persistentmodels"]
roots = []
comment-token = "--"
indent = { tab-width = 2, unit = " " } |
Moved recognition of language name into the haskell injection queries, added folds, and marked |
the-mikedavis
approved these changes
Jul 9, 2023
pascalkuthe
approved these changes
Jul 9, 2023
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the language used by a persistent library to define the database models. This syntax is only used by one library, so I chose to prefix the language name with "haskell-" for specificity.
The haskell injections query uses the name of the function that handles that content of the quasi-quote as the name of the language. The persistent library has three of them that I included into the
injection-regex
.