LSP: Key diagnostics off file path instead of URI

[the-mikedavis]

URIs need to be normalized to be comparable. For example a language server could send a URI for a path containing + as %2B but we might encode this in something like Document::url as just +. We can normalize the URI straight into a PathBuf though since this is the only value we compare these diagnostics URIs against. This also covers edge-cases like windows drive letter capitalization.

Closes #3267
Also see #7321 (thanks for the pointer on this @pascalkuthe!)

[pascalkuthe]

Thanks for working on this!

[sbromberger]

This PR might fix the problem where a directory has a + sign: LSP doesn't work in these directories since the URI is normalized/encoded:

helix_lsp::transport [INFO] clangd <- {"jsonrpc":"2.0","method":"textDocument/publishDiagnostics","params":{"diagnostics":[{"code":"undeclared_var_use","message":"Use of undeclared identifier 'lkasdjlkasdj'","range":{"end":{"character":14,"line":18},"start":{"character":2,"line":18}},"severity":1,"source":"clang"}],"uri":"file:///home/me/dev/c%2B%2B/advcpp/test.cpp","version":0}}

[kayoscode]

I'm getting this issue on windows as well. Helix version 23.10

[the-mikedavis]

Yep this should fix how we find the right document for diagnostics for both windows drive letters and any paths that a language server might URL-encode (+, @, etc.)

[gzmorell]

Applying this patch in windows brings diagnosis back. Thanks a lot