Allow any indent size from 1 to 16 #7429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, helix only allowed indent sizes from 1-8, but this isn't anything fundamental. This commit changes to allow any indent sizes that fit within a u8. This commit is motivated by a hackernews user who has a deranged desire to have a 12 space indent. See request here: https://news.ycombinator.com/item?id=36429221 Code motivated by suggestions here: https://news.ycombinator.com/item?id=36432996
|
#7178 the limit is 16, so the static string should be limited to that. |
|
That's tab width and not indent width. That said I still think that a value of 16 is large enough. |
Unfortunately, my first PR was too deranged for the maintainers of helix. :( I have restricted the indents to be only 1-16.
pascalkuthe
reviewed
Jun 22, 2023
Now clamping both in `IndentStyle`'s `to_str` and `from_str` methods. Also added a constant to be clearer where the random 17's and 16's are throughout the file.
|
Okay, all suggestions fixed and clippy should be happy. I also added a constant so it's clear why the literals were chosen, but I can put it back to literals if it's preferred. Also, I didn't see a good way to test the failing case where indent > 16 specifically because behavior could vary between debug and release builds (debug will panic for indent > 16 while release will pass with indent = 16) |
the-mikedavis
changed the title
the-mikedavis
approved these changes
Jun 23, 2023
the-mikedavis
added
C-enhancement
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, helix only allowed indent sizes up to 8. This commit changes to allow any indent sizes that fit within a u8.
This pr is motivated by a hackernews user with a
derangednormal desire to have a 12 space indent.See request here: https://news.ycombinator.com/item?id=36429221
Code motivated by suggestions here: https://news.ycombinator.com/item?id=36432996
I used a single line of 256 spaces because it's super simple and easy to validate rather than using an additional dependency like const_format or writing a macro myself.