Add asm (assembler) language support based on tree-sitter-asm #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tree-sitter-asm syntax is more suitable for generic assembly language, including GNU assembler syntax, than the NASM-specific one. This changes extensions for NASM so that asm syntax is used for ".s" and ".S" files, which are commonly used with the GNU assembler, and ".asm" and ".nasm" for NASM which are more commonly used with that.
|
|
||
| [[grammar]] | ||
| name = "asm" | ||
| source = { git = "https://github.com/rush-rs/tree-sitter-asm.git", rev = "36dc26acc7818920de2e103e20a9f42358caf926" } |
There was a problem hiding this comment.
Suggested change
| source = { git = "https://github.com/rush-rs/tree-sitter-asm.git", rev = "36dc26acc7818920de2e103e20a9f42358caf926" } | |
| source = { git = "https://github.com/rush-rs/tree-sitter-asm", rev = "36dc26acc7818920de2e103e20a9f42358caf926" } |
There was a problem hiding this comment.
The highlights should use helix's capture names: https://docs.helix-editor.com/master/themes.html#syntax-highlighting
It looks like they're currently using nvim-like captures. For example (int) @number should be (int) @constant.numeric.integer.
| kind: (_) @function.call) | ||
|
|
||
| ; Comments | ||
| (line_comment) @comment @spell |
There was a problem hiding this comment.
Suggested change
| (line_comment) @comment @spell | |
| (line_comment) @comment |
|
This is superseded by #8291 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tree-sitter-asm syntax is more suitable for generic assembly language, including GNU assembler syntax, than the NASM-specific one.
This changes extensions for NASM so that asm syntax is used for ".s" and ".S" files, which are commonly used with the GNU assembler, and ".asm" and ".nasm" for NASM which are more commonly used with that.
The only thing I'm not sure about is tree-sitter-asm had highlight queries in the package already, so I just copied those but appended the LICENSE file to the beginning. Since it's MIT license I hope this is not a problem, but unfortunately I'm not the author of tree-sitter-asm so I can't help you with that. It would probably be more ideal if helix could also include highlight queries from git while building the grammars rather than having to be in the main helix repo.