Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(comment): fix incorrect predicate #7732

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix(comment): fix incorrect predicate #7732

merged 1 commit into from
Jul 25, 2023

Conversation

lucario387
Copy link
Contributor

These 2 captures were missing # so it's not working as intended

Was there any particular reason they were done as such?

the-mikedavis
the-mikedavis approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's just an oversight. Thanks for the fix!

@the-mikedavis the-mikedavis added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-language-support Area: Support for programming/text languages labels Jul 25, 2023
@pascalkuthe pascalkuthe merged commit 75239a9 into helix-editor:master Jul 25, 2023
6 checks passed
@lucario387 lucario387 deleted the fix-incorrect-pred branch July 26, 2023 02:06
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@lucario387 @mtoohey31
fix incorrect predicate in comment highlights (helix-editor#7732)
90e8752
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@lucario387
fix incorrect predicate in comment highlights (helix-editor#7732)
7aa2d36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-language-support Area: Support for programming/text languages C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucario387 @the-mikedavis @pascalkuthe