Refactor Nix flake to use crane #7763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
C-bug
pascalkuthe
previously approved these changes
Jul 27, 2023
the-mikedavis
force-pushed
the
nix-flake-crane
branch
from
e86b983
to
34398d4
Compare
the-mikedavis
force-pushed
the
nix-flake-crane
branch
from
34398d4
to
834b7b6
Compare
archseer
reviewed
Jul 28, 2023
This resolves a build issue with nci/dream2nix and git dependencies. We can keep most of the helix-specific parts of the flake, we just need to switch from configuring nci to calling craneLib functions. We also switch to flake-utils from flake-parts: * Using rust-overlay with flake-parts directly is unergonomic (see hercules-ci/flake-parts#83). * Removing flake-parts reduces the overall dependencies: rust-overlay already depends on flake-utils.
the-mikedavis
force-pushed
the
nix-flake-crane
branch
from
834b7b6
to
2c1e1bf
Compare
the-mikedavis
commented
Jul 28, 2023
| nci = { | ||
| url = "github:yusdacra/nix-cargo-integration"; | ||
| inputs.nixpkgs.follows = "nixpkgs"; | ||
| crane = { |
There was a problem hiding this comment.
We could also remove crane and use only rust-overlay like nil does. Crane has some nice helpers for the checks and it seems to be very popular and stable though so I think it's fine to depend on it for now. If it becomes a problem in the future though, pure rust-overlay is an option
Merged
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
This resolves a build issue with nci/dream2nix and git dependencies. We can keep most of the helix-specific parts of the flake, we just need to switch from configuring nci to calling craneLib functions. We also switch to flake-utils from flake-parts: * Using rust-overlay with flake-parts directly is unergonomic (see hercules-ci/flake-parts#83). * Removing flake-parts reduces the overall dependencies: rust-overlay already depends on flake-utils.
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
This resolves a build issue with nci/dream2nix and git dependencies. We can keep most of the helix-specific parts of the flake, we just need to switch from configuring nci to calling craneLib functions. We also switch to flake-utils from flake-parts: * Using rust-overlay with flake-parts directly is unergonomic (see hercules-ci/flake-parts#83). * Removing flake-parts reduces the overall dependencies: rust-overlay already depends on flake-utils.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a build issue with nci/dream2nix and git dependencies. We can keep most of the helix-specific parts of the flake, we just need to switch from configuring nci to calling craneLib functions.
We also switch to flake-utils from flake-parts:
Closes #7761