Fix find commands for buffers with non-LF line-endings #8111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woojiq
force-pushed
the
find_char_ret
branch
2 times, most recently
from
4cc2c1d
to
7ad3c3c
Compare
pascalkuthe
reviewed
Sep 1, 2023
There was a problem hiding this comment.
I think this is an ok fix (the implementation seems correct) but I think a better solution would be to special case this branch. And just use ropey to find the next line ending/start from the cursor (look at the implementation of gl/gh). That should be faster and correctly handle files with mixed line endings (resolving the TODO comment here)
pascalkuthe
added
C-bug
woojiq
force-pushed
the
find_char_ret
branch
2 times, most recently
from
17b55e0
to
557a34a
Compare
|
Done. Thank you for the suggestion. There are some edge cases thought. Comments explain them more clearly. |
pascalkuthe
reviewed
Sep 2, 2023
woojiq
changed the title
pascalkuthe
previously approved these changes
Sep 2, 2023
pascalkuthe
added
S-waiting-on-review
* Takes into account direction and an inclusive flag to select the first or last char of the line-ending string. * Adds tests to ensure `T` and `F` work with `\n` and `\r\n` line-endings.
woojiq
force-pushed
the
find_char_ret
branch
from
f16a6c9
to
3aebade
Compare
pascalkuthe
previously approved these changes
Sep 3, 2023
the-mikedavis
approved these changes
Sep 3, 2023
the-mikedavis
changed the title
pascalkuthe
approved these changes
Sep 3, 2023
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds separate method for finding
<ret>char.Closes #8057
Resolves TODO:
helix/helix-term/src/commands.rs
Lines 1270 to 1273 in 79c0425