Theme: Papercolor: Cleanup, linting and using inheritance #8276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regular Vim does not handle multiple selections, add distinction between primary and secondary cursors. Align dark and light variants, smaller cleanup
And cursorline/cursorcolumn
Align light and dark variants, use inherit feature
|
\cc @uncomfyhalomacro what do you think of the changes? |
the-mikedavis
added
A-theme
|
@AfoHT Nice changes. I think this is good for merging @the-mikedavis 😄 |
the-mikedavis
approved these changes
Sep 13, 2023
pascalkuthe
approved these changes
Sep 13, 2023
dgkf
pushed a commit
to dgkf/helix
that referenced
this pull request
Jan 30, 2024
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started out as just fixing the lints, ended up being a bit more substantial overhaul.
Primary changes:
inheritsfeatureMinor changes:
Light
Old
New
Vim
Dark
Old
New
Vim
For both light and dark Vim screenshots, the cursor should be filled in, just like in Helix. Due to loss of focus when taking screenshots we get the boxed in letter variant instead.