refine darcula and darcula-solid themes #8412
Conversation
the-mikedavis
changed the title
the-mikedavis
added
A-theme
|
I would keep the default cursor shape for secondary selections, the underline seems more like a stylistic choice |
|
I concur, the secondary selection color seems like an upgrade to me but let's keep the original cursor shape. |
|
This looks good to me. I also agree that we should keep the default cursor shape for secondary selections. Thanks for the contribution. |
runtime/themes/darcula.toml
Outdated
| "ui.statusline" = { fg = "grey04", bg = "grey02" } | ||
| "ui.statusline.insert" = { bg = "white", fg = "grey01" } | ||
| "ui.statusline.select" = { bg = "orange", fg = "grey01" } | ||
| "ui.help" = { fg = "grey04", bg = "grey01" } | ||
| "ui.cursor" = { fg = "grey04", modifiers = ["reversed"] } | ||
| "ui.cursor" = { bg = "grey02", modifiers = ["underlined"] } |
There was a problem hiding this comment.
As discussed lets keep this as the default.
|
I made changes to secondary cursor because for some reasons they seem to be distracting for me master
changed version
BugAnd seems like I'm introducing a bug with these changes for darcula-solid because now it's not possible to say which argument we're on in documentation popups
With the following changes on
how it looks in master
for just darcula it looks pretty finemaster
changed version
markup.rawAnd if you don't mind can we change
to
|
|
Everything looks great now to me. Just the PR title should be updated to reflect the more extensive changes. |
boofexxx
changed the title
master branch:
darcula:
darcula-solid:
changed version:
darcula:
darcula-solid: