Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modus operandi themes #8728

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

amousset
Copy link
Contributor

@amousset amousset commented Nov 6, 2023

This PR adds themes based on the light variants of the carefully designed modus themes (built-in with Emacs). This is not a port of the original theme, as Emacs themes are much more than a color scheme, but a set of Helix themes inspired by the defaults of the modus operandi (light) theme, and reusing their color palette. They follow the same goals, i.e. legibility and accessibility (following the highest WCAG AAA standard), even over esthetics when necessary.

The themes are:

  • modus_operandi: the base theme
  • modus_operandi_tritanopia: a variant of the base theme for blue-yellow color deficiency
  • modus_operandi_deuteranopia: a variant of the base theme for red-green color deficiency
  • modus_operandi_tinted: a variant with a toned-downed background

modus operandi
Screenshot from 2023-11-06 02-29-41

modus operandi tinted
Screenshot from 2023-11-06 02-24-30
Screenshot from 2023-11-06 02-23-48
Screenshot from 2023-11-06 02-23-12-1

Licensing note: Even if the theme for Emacs is licensed under GPLv3+, the color palette itself is placed under CC0.

@the-mikedavis the-mikedavis added A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer. labels Nov 6, 2023
Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer, but a modus fan! This is really cool, thank you for this :D

@pascalkuthe pascalkuthe merged commit 090ed97 into helix-editor:master Nov 22, 2023
6 checks passed
@aboe76
Copy link

aboe76 commented Nov 22, 2023

@amousset will you try to add the 'modus-vivendi' variants as well?

@atahrijouti
Copy link
Contributor

@amousset and https://protesilaos.com/emacs/ef-themes too please :-)

@matoous
Copy link
Contributor

matoous commented Nov 23, 2023

@aboe76 here's a draft, you can give it a try: #8894

@amousset
Copy link
Contributor Author

I don't plan to work on additional modus themes for now (but it seems @matoous does 👍 )

@aboe76
Copy link

aboe76 commented Nov 24, 2023

@aboe76 here's a draft, you can give it a try: #8894

Yes thank you @matoous, just compiled your PR and it works nicely

dgkf pushed a commit to dgkf/helix that referenced this pull request Jan 30, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants