Use content_inspector create to remove binaries from file picker #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you seen #939? |
|
I had not! I can close this in favor of the other if you like. |
|
Reviewed #939 in full, closing in favor of that as it looks much more robust. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands on #767 in the suggested way -- by pulling in some logic that sniffs the first kilobyte of a file for the type of file. I'm unsure what the impact of this is going to be on large codebases like say the linux kernel, but the hope is that filtering out much of the uneditable/binary file types by extension first (as in the previous pull request) will mitigate that.
If the approach is acceptable, I'll build on this pull request with commits adding further file extensions to exclude prior to the binary sniffing, as in the previous pull request.