Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect undercurl config even with no terminfo #9897

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Respect undercurl config even with no terminfo #9897

merged 1 commit into from
Mar 19, 2024

Conversation

iceghost
Copy link
Contributor

@iceghost iceghost commented Mar 16, 2024 •
edited
Loading

I have just found out that my recent Windows Terminal version supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release ). However, looking at the source, terminfo is required for helix to emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the editor.undercurl option when there is no terminfo.

Tested on Windows Terminal Preview 1.20. Works without WSL.

image

Fixes #7065?

@iceghost
Respect undercurl config even with no terminfo
984eaa8 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
@the-mikedavis the-mikedavis added A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Mar 17, 2024
@pascalkuthe pascalkuthe merged commit 4d2282c into helix-editor:master Mar 19, 2024
6 checks passed
@iceghost
Copy link
Contributor Author

Thanks for the merge!

Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
@iceghost @Desdaemon
Respect undercurl config even with no terminfo (helix-editor#9897)
79c9082 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@iceghost @postsolar
Respect undercurl config even with no terminfo (helix-editor#9897)
295dba0 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@iceghost @postsolar
Respect undercurl config even with no terminfo (helix-editor#9897)
673ffbb 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@iceghost @postsolar
Respect undercurl config even with no terminfo (helix-editor#9897)
0b3180c 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@iceghost @postsolar
Respect undercurl config even with no terminfo (helix-editor#9897)
3e37e64 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@iceghost @mtoohey31
Respect undercurl config even with no terminfo (helix-editor#9897)
1f65362 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@iceghost @Vulpesx
Respect undercurl config even with no terminfo (helix-editor#9897)
7db7058 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@iceghost
Respect undercurl config even with no terminfo (helix-editor#9897)
1e087ce 
I have just found out that my recent Windows Terminal version
supported rendering undercurl (see
https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-20-release
). However, looking at the source, terminfo is required for helix to
emit the undercurl control code, which isn't available on Windows AFAIK.

This commit make helix respects the `editor.undercurl` option when
there is no terminfo.

Tested on Windows Terminal Preview 1.20

Signed-off-by: Khang Nguyen <khang.nguyenduycse@hcmut.edu.vn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archseer archseer archseer approved these changes

@pascalkuthe pascalkuthe pascalkuthe approved these changes

Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underline ignores its color
4 participants
@iceghost @archseer @pascalkuthe @the-mikedavis