Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Adding owner to the Datadog chart #8911

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Conversation

CharlyF
Copy link
Collaborator

@CharlyF CharlyF commented Oct 30, 2018

What this PR does / why we need it:

Adding a new owner to the Datadog Chart.

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: charlyF charly@datadoghq.com

Signed-off-by: charlyF <charly@datadoghq.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 30, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 30, 2018
@irabinovitch
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@irabinovitch: changing LGTM is restricted to assignees, and only helm/charts repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@irabinovitch
Copy link
Contributor

/approve

1 similar comment
@hkaj
Copy link
Collaborator

hkaj commented Nov 1, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@hkaj
Copy link
Collaborator

hkaj commented Nov 1, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlyF, hkaj, irabinovitch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2018
@hkaj
Copy link
Collaborator

hkaj commented Nov 1, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit c6c134b into helm:master Nov 1, 2018
@CharlyF CharlyF deleted the add-owner branch November 1, 2018 16:57
pmontanari pushed a commit to pmontanari/charts that referenced this pull request Nov 2, 2018
Signed-off-by: charlyF <charly@datadoghq.com>
Signed-off-by: Patrick Montanari <patrick.montanari@gmail.com>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
Signed-off-by: charlyF <charly@datadoghq.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants