Fix code consistency for value reading

hemtjanst · Jun 30, 2022 · c6a0453 · c6a0453
1 parent e336fc1
commit c6a0453
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/collectors/environmental.go b/collectors/environmental.go
@@ -140,8 +140,8 @@ func (c *EnvironmentalCollector) Collect(ch chan<- prometheus.Metric) {
 	temperature := map[string]float64{}
 
 	for _, s := range devices {
-		if s.Feature(feature.CurrentRelativeHumidity.String()).Exists() {
-			v := s.Feature(feature.CurrentRelativeHumidity.String()).Value()
+		if ft := s.Feature(feature.CurrentRelativeHumidity.String()); ft.Exists() {
+			v := ft.Value()
 			if v == "" {
 				continue
 			}
@@ -154,8 +154,8 @@ func (c *EnvironmentalCollector) Collect(ch chan<- prometheus.Metric) {
 			ch <- prometheus.MustNewConstMetric(c.relativeHumidity,
 				prometheus.GaugeValue, vf, s.Info().Topic)
 		}
-		if s.Feature(feature.CurrentTemperature.String()).Exists() {
-			v := s.Feature(feature.CurrentTemperature.String()).Value()
+		if ft := s.Feature(feature.CurrentTemperature.String()); ft.Exists() {
+			v := ft.Value()
 			if v == "" {
 				continue
 			}