feat: remove NASM dependency #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
rm-nasm
branch
7 times, most recently
from
0c4c071
to
db20d6e
Compare
This migrates the x86-64 application processor boot code from NASM to GNU assembly language. `boot.asm` is replaced by `boot.s`. Instead of NASM directives, their GNU assembler (`as`) equivalents are used. This assembly file is embedded in an LLVM assembly language file with only one module level (global) assembly statement. Rust bundles `llvm-as`, which we use to translate the LLVM assembly to LLVM bitcode. The resulting file is linked to binary using the bundled `rust-lld`. The final binary is exactly the same as before, bit for bit. This finally removes NASM as the last non-Rust toolchain dependency. Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
|
You want that I am not longer able to extend the code? :-) |
|
Ok, you use "intel syntax"... |
stlankes
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the x86-64 application processor boot code from NASM to GNU assembly language.
boot.asmis replaced byboot.s.Instead of NASM directives, their GNU assembler (
as) equivalents are used.This assembly file is embedded in an LLVM assembly language file with only one module level (global) assembly statement.
Rust bundles
llvm-as, which we use to translate the LLVM assembly to LLVM bitcode.The resulting file is linked to binary using the bundled
rust-lld.The final binary is exactly the same as before, bit for bit.
This finally removes NASM as the last non-Rust toolchain dependency.
Closes #914