Fix support for Heroku-24 #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-salesforce
force-pushed
the
jason/h24
branch
2 times, most recently
from
11c9973
to
8884d58
Compare
jason-salesforce
force-pushed
the
jason/h24
branch
from
8884d58
to
a7a3fa2
Compare
these no longer exist
jason-salesforce
force-pushed
the
jason/h24
branch
from
3b993c9
to
cf26f51
Compare
To make testing fully representative of the Heroku platform, we have to run the built app against the run image and not the build image. (Whilst Heroku CI will use the build image, some apps will use the buildpack outside of CI, and so against the run image which has fewer system libraries than the build image.)
This prevents unnecessary Docker cache invalidation when editing files that don't affect the image, meaning quicker iteration times when developing on this buildpack locally.
edmorley
reviewed
May 30, 2024
Fixes this error: ``` chrome: error while loading shared libraries: libasound.so.2: cannot open shared object file: No such file or directory ``` And also cleans up the packages list, removing some packages that either are no longer needed, or already exist in the base image. This is safe to do now that `bin/test.sh` checks for missing shared libraries.
|
Thanks @edmorley! |
|
@jason-salesforce No problem! (I've been doing quite a few similar testing setups for missing dynamic libs etc in other repos, so thought it might save you some hassle if I pushed some changes rather than try and use review suggestion code blocks etc :-) ) |
|
With the new setup debugging should be a lot easier in the future - you run |
edmorley
approved these changes
May 30, 2024
|
GitHub release created: And published to the buildpack registry: |
edmorley
added a commit
that referenced
this pull request
Jun 21, 2024
- Trims the APT package list for Heroku-20 and Heroku-22 to match the packages list used for Heroku-24. - Uses `--no-install-recommends` to avoid pulling in unnecessary transitive dependencies. - Now outputs the size of the app dir when running tests (plus removes test containers after they exit). The tests added in #15 ensure that there are no missing dynamically linked libraries, and that Chrome + Chromedriver can start. This reduces the uncompressed slug size impact of this buildpack as follows: - Heroku-20: 442 MB -> 350 MB - Heroku-22: 426 MB -> 351 MB - Heroku-24: 381 MB -> 353 MB Fixes #17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also changes the test to run inside of a dockerfile using our base builder images. Prior to this, we were getting passing tests on a broken heroku-24 build that was attempting to install packages that no longer exist in ubuntu 24.