Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use fully qualified container name #690

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

apricote
Copy link
Member

@apricote apricote commented Jul 8, 2024

Mostly to make sure we are consistent with our other kubernetes integration: csi-driver.

Mostly to make sure we are consistent with our other kubernetes
integration: csi-driver.
@apricote apricote self-assigned this Jul 8, 2024
@apricote apricote requested a review from a team as a code owner July 8, 2024 09:21
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.26%. Comparing base (1a8ea95) to head (3c295c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #690      +/-   ##
==========================================
+ Coverage   72.16%   72.26%   +0.09%     
==========================================
  Files          31       32       +1     
  Lines        2497     2668     +171     
==========================================
+ Hits         1802     1928     +126     
- Misses        523      552      +29     
- Partials      172      188      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricote apricote merged commit 0e6d96f into main Jul 8, 2024
8 checks passed
@apricote apricote deleted the fq-container-name branch July 8, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants