fix: change annotation LBSvcRedirectHTTP to "https"

[a-mader]

Hi,

I think this should be renamed from "http-to-http" to "http-to-https" and this would be a breaking change.

Closes #656

Kind regards

[apricote]

Thanks for the PR @a-mader,

this is indeed a breaking change, so I will not merge it as is.

I wrote a bit about the origin of the current annotation and the alternative I would like to see in #656 (comment).

If you want you can adjust this PR to match my suggestion in the linked comment.

[a-mader]

Hi @apricote,

what do you think about having both annotations available, but marking the old one for deprecation?

e.g.

• LBSvcRedirectHTTP marked for deprecation
• LBSvcRedirectHTTPS new annotation

// MARKED FOR DEPRECATION (LBSvcRedirectHTTP create a redirect from HTTP to HTTPS. HTTPS only.)
LBSvcRedirectHTTP Name = "load-balancer.hetzner.cloud/http-redirect-http"

// LBSvcRedirectHTTP create a redirect from HTTP to HTTPS. HTTPS only. Bool either "true" or "false"
LBSvcRedirectHTTPS Name = "load-balancer.hetzner.cloud/http-redirect-https"

and update the documentation to use the new annotation.

Kind regards