Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth too slow #21

Closed
hexfusion opened this issue Jun 17, 2017 · 1 comment
Closed

Auth too slow #21

hexfusion opened this issue Jun 17, 2017 · 1 comment
Milestone
v0.3.0

Comments

@hexfusion
Copy link
Owner

We are requesting a new token every connection. Locally on my SSD laptop this is not a problem but for example traveis sees pretty heavy delays causing failures in tests. Need to cache the token and if it is invalid refresh and submit request again.
@hexfusion hexfusion added this to the v.020 milestone Jun 17, 2017
@hexfusion
Copy link
Owner Author

resolved via #18

hexfusion added a commit that referenced this issue Nov 24, 2017
@hexfusion
Properly check status of callback. Fixes (GH #21)
c0fa64e 
* Because we were not checking this tests were not returning success in some circumstances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
1 participant
@hexfusion