Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[perfomance] Support native copyFile. #8

Closed
segayuu opened this issue Sep 19, 2017 · 1 comment · Fixed by #9
Closed

[perfomance] Support native copyFile. #8

segayuu opened this issue Sep 19, 2017 · 1 comment · Fixed by #9
Labels
enhancement

Comments

@segayuu
Copy link
Contributor

segayuu commented Sep 19, 2017 •
edited
Loading

fs.copyFile() and fs.copyFileSync() were implemented in Node.js 8.5.0.
nodejs/node#14906
nodejs/node#15034

This function uses OS native commands, and projects such as yarn have already succeeded in speeding up.

Leave the current implementation as fallback and make suggestions to use the navive function from the implemented version for the purpose of optimization.
@JLHwung JLHwung mentioned this issue Sep 19, 2017
Merged
@NoahDragon
Copy link
Member

Thanks for @JLHwung , we will merge the PR for 0.2.3.

@segayuu segayuu closed this as completed Sep 19, 2017
JLHwung added a commit that referenced this issue Sep 20, 2017
@JLHwung
Merge pull request #9 from hexojs/copyfile
6f5800f 
feat(copyFile): use native fs.copyFile when available, closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(copyFile): use native fs.copyFile when available hexojs/hexo-fs
2 participants
@NoahDragon @segayuu