HH-76991 remove jdebug dependency, rename properties file #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhalikov
commented
Mar 2, 2018
| return subProperties; | ||
| } | ||
|
|
||
| public FileSettings getSubSettings(String prefix) { | ||
| return new FileSettings(getSubProperties(prefix)); | ||
| } | ||
|
|
||
| public List<String> getStringList(String key) { |
There was a problem hiding this comment.
Для совместимости с hh.ru
troy4eg
reviewed
Mar 2, 2018
| @@ -31,20 +34,31 @@ public Boolean getBoolean(String key) { | |||
| } | |||
|
|
|||
| public Properties getSubProperties(String prefix) { | |||
| final String namespacePrefix = Strings.isNullOrEmpty(prefix) ? "" : prefix + "."; | |||
| if (Strings.isNullOrEmpty(prefix)) { | |||
There was a problem hiding this comment.
мне кажется можно обычный assert
There was a problem hiding this comment.
Заиспользовал спринговый Assert.hasLength.
akhalikov
commented
Mar 2, 2018
| @@ -186,12 +180,6 @@ | |||
| </exclusions> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>ru.hh</groupId> | |||
| <artifactId>timings</artifactId> | |||
There was a problem hiding this comment.
Пока не используются.
troy4eg
approved these changes
Mar 2, 2018
|
Схлопнул коммиты. |
|
Довыпил использование guava из nab-hibernate и nab-testbase. |
|
Обновил README. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings.propertiesвservice.properties.FileSettings.https://jira.hh.ru/browse/HH-76991