Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert WebItem, Item and Favorite from java to Kotlin #1154

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Convert WebItem, Item and Favorite from java to Kotlin #1154

wants to merge 3 commits into from

Conversation

yoavst
Copy link

@yoavst yoavst commented Oct 7, 2018

While doing this PR, I noticed that [Favorite.url] is referenced as non-null everywhere, but a single test passes null to it. Probably should convert it to non-null and fix the test.

Edit:
do you have any idea how to make the lint pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant