Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: properly localize the sitemaps #373

Merged
merged 4 commits into from
Jan 31, 2024
Merged

feat: properly localize the sitemaps #373

merged 4 commits into from
Jan 31, 2024

Conversation

ramboz
Copy link
Collaborator

@ramboz ramboz commented Jan 30, 2024 •
edited
Loading

Adds properly localized sitemaps:

  • add a sitemap index listing all regional ones
  • add a new helix query definition for the UK sitemap
  • add a new helix sitemap definition for the UK sitemap

Test URLs:

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 30, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Jan 30, 2024 •
edited
Loading

Page Scores Audits Google
/sitemap-en-gb.xml Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/xml). PSI
/sitemap-index.xml Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type application/xml). PSI
/sitemap.xml Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/xml). PSI

@ramboz ramboz mentioned this pull request Jan 30, 2024
Open
57 tasks
@ramboz ramboz requested a review from mfrisbey January 30, 2024 09:21
@ramboz ramboz marked this pull request as ready for review January 30, 2024 09:21
@ramboz ramboz merged commit eddc397 into main Jan 31, 2024
1 of 2 checks passed
@ramboz ramboz deleted the localized-sitemap branch January 31, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfrisbey mfrisbey mfrisbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramboz @mfrisbey