feat: Added AEM Asset Selector sidekick configs #10
Conversation
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
|
|
|
|
|
|
@dylandepass , @auniverseaway tagging you to get some initial feedback on this. I recorded the flow here for reference https://adobe-my.sharepoint.com/:v:/p/satyam/EZ8xJJwsM-FGoir3RGFzPKsBjED9-PfBGp9uPwD_rRKw3w?e=QcesOa |
|
|
@sdmcraft This is great start. Couple thoughts.. I wonder if we could run this off franklin and bypass the need for the netlify app? That would be ideal I think. I had some issues connecting to prod. Seems to always want to default to stage, even from their configuration screen? Were you able to connect to prod? We have a prod instance we'd like to use for the wknd, so would be nice to connect to that. I'm surprised this is the login experience they provided. This should ideally use the discovery service to allow users to pick from a list of available repositories instead of requiring all the configuration. |
|
Thanks for taking out the time to review @dylandepass .
Yes after the latest changes, netlify app isn't needed anymore. Everything is now hosted within Franklin itself. I think you would be getting redirected to the netlify app as that's set as the default redirect url in the IMS client that I created for this. I am facing some issues with IMS auth flow redirections. I am not allowed to specify the wknd site as the
There were a few issues connecting with prod which I fixed yesterday. It should work with prod as well now. The word doc where the configurations are set is here . You can try setting the AEM Wknd env co-ordinates in it or share with me and I can try it out.
Hm..that's a great point. This is something I need to check with the Asset selector team. Basically I am following the setup documented here with some tweaks to make it work within Franklin. I'll check about the repository picker experience. |
|
|
|
|
|
|
|
|
@dylandepass , thanks for guiding me on this. Also copying @davidnuescheler for his inputs. On the IMS SSO login experience, I worked with the asset selector team and now specifying the AEM details etc. is not longer needed. The only configuration needed is the IMS org. This is also temporary till https://jira.corp.adobe.com/browse/ASSETS-22140. |
|
@sdmcraft I did speak with @davidnuescheler about this earlier this week. I think the biggest blocker to putting this in right now is the requirement on having to manage adding sales folks to the org with the Assets Essentials instance for WKND. I think in a typical franklin site the login requirement is totally fine and expected. This repo though is meant to be more of sales tool so we want to minimize demo friction as much as possible. We discussed a couple options.
Any thoughts on that @sdmcraft? @davidnuescheler mentioned that the AEM Assets team is currently working on a more "Franklinized" version of Assets which might be another area of exploration. |
|
On the login requirement, I think the easiest path is to create a group in admin console and grant it access to wknd AEM instance. And then upload a list of users in csv format (if we can manage to create such a list) via bulk upload in admin console. That way all of them get access by virtue of their group membership. Another path could be that the sales reps login to whichever AEMCS Env they have access to and just use the assets from there instead of all logging into the same AEM Wknd instance.
Indeed. I think there's some work being done for content-lake and definitely worth exploring. Though in this specific prototype, the primary intent is to show the value by being able to use assets which the users may already have in their traditional AEM based enterprise repositories. |
|
|
|
Since |
|
|
|
|
|
Closing this for lack of any progress. |
e79706d fix: make sure the pill is not shown on live and prod hosts 21890bb fix: improve production host detection to better cover edge cases 2034373 fix: pill does not show any results even if RUM endpoint contains data 53696f4 fix: RUM endpoint url returns empty results fee6692 Update README.md 46e6a48 Update README.md 4ff6246 fix: leaking heading styles into the pill 02617d2 fix: sanitize experiment and variant names for proper css class injection d6318cf fix: gracefully handle projects where block-level experiments aren't instrumented 162896d Update README.md 06a92c5 feat: update plugin to leverage v3 RUM APIs and domain key (hlxsites#10) b033075 doc: add warning about recent sampleRUM b4d3dab fix: track rum when selected variant is control (hlxsites#9) git-subtree-dir: plugins/experimentation git-subtree-split: e79706d94597806c70bd32a50e76b49ea5ee169a
e04a21c fix: fetch without plain selector (#19) 4b4a853 fix: active status sanitization 4b6fa0d feat: add support for setting experiment status, start date and end date 0b293f1 fix: always await replaceInner (#18) 3ec48c9 fix: invalid url when given a path for variant (#14) d9f3d01 fix: issue 11 (#12) 9e7b01a fix: expose resolved audiences when running campaigns e79706d fix: make sure the pill is not shown on live and prod hosts 21890bb fix: improve production host detection to better cover edge cases 2034373 fix: pill does not show any results even if RUM endpoint contains data 53696f4 fix: RUM endpoint url returns empty results fee6692 Update README.md 46e6a48 Update README.md 4ff6246 fix: leaking heading styles into the pill 02617d2 fix: sanitize experiment and variant names for proper css class injection d6318cf fix: gracefully handle projects where block-level experiments aren't instrumented 162896d Update README.md 06a92c5 feat: update plugin to leverage v3 RUM APIs and domain key (#10) b033075 doc: add warning about recent sampleRUM b4d3dab fix: track rum when selected variant is control (#9) git-subtree-dir: plugins/experimentation git-subtree-split: e04a21c732dbc33ec46ace47121cb2785faf49e3
e02b92a feat: add support for experimentation c80c985 feat: add support for experimentation e04a21c fix: fetch without plain selector (#19) 4b4a853 fix: active status sanitization 4b6fa0d feat: add support for setting experiment status, start date and end date 0b293f1 fix: always await replaceInner (#18) 3ec48c9 fix: invalid url when given a path for variant (#14) d9f3d01 fix: issue 11 (#12) 9e7b01a fix: expose resolved audiences when running campaigns e79706d fix: make sure the pill is not shown on live and prod hosts 21890bb fix: improve production host detection to better cover edge cases 2034373 fix: pill does not show any results even if RUM endpoint contains data 53696f4 fix: RUM endpoint url returns empty results fee6692 Update README.md 46e6a48 Update README.md 4ff6246 fix: leaking heading styles into the pill 02617d2 fix: sanitize experiment and variant names for proper css class injection d6318cf fix: gracefully handle projects where block-level experiments aren't instrumented 162896d Update README.md 06a92c5 feat: update plugin to leverage v3 RUM APIs and domain key (#10) b033075 doc: add warning about recent sampleRUM b4d3dab fix: track rum when selected variant is control (#9) git-subtree-dir: plugins/experimentation git-subtree-split: e02b92a0a46a2c2d3dbb111f63859b613303ef9d
Test URLs: