Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scheduling functionality #23

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add scheduling functionality #23

wants to merge 2 commits into from

Conversation

herzog31
Copy link

@herzog31 herzog31 commented Aug 15, 2023

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

  • Added a sidekick extension that adds a date field to preview scheduled content.
    • If you want to test this, please checkout this PR locally and update the sidekick options (advanced) to use a local config file.
  • Scheduled date for sections can be added via Section Metadata block.
  • Scheduling for blocks can be added via a date row.
  • Empty sections will not be automatically deleted. Instead add scheduling to them.
  • If a simple date is defined, the block/section will be displayed after that date.
  • If a date range is defined, the block/section will be displayed only in that range.
  • Not suitable for confidential data, since the scheduled content will still be in the DOM.

Example:
image

You can test scheduling on https://scheduling--wknd--hlxsites.hlx.live/drafts/mabecker/scheduling

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 15, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 15, 2023

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/drafts/mabecker/scheduling PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@pnamadobe
Copy link

pnamadobe commented Aug 7, 2024

hi, i have customers asking about this. is there a rough timeframe for this to get into main?
Also, what if we hash the (not yet published) text with a key that is fetched. async and the key is only published at the appropriate time?
nvm. that would probably kill performance scores.

@herzog31
Copy link
Author

@pnamadobe this implementation will stay in block party mode. Feel free to copy the code over to your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants