Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PODS-9123: #216

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

PODS-9123: #216

wants to merge 3 commits into from

Commits on Feb 13, 2024

  1. PODS-9123:

    Code:
    - Added auth action which cross references data from the list of legacy schemes and legacy scheme details APIs. It checks whether a given PSA or PSA/PSTR combination has access to data for a scheme and uses the schemeName field, common to both responses, for matching purposes. If the schemeName doesn't match or other failures occur you will reach Page not found.
    - Removed unused custom exception
    ngmjohnstone committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    d61da89 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. PODS-9123: Addressing PR comments

    Code:
    - Added type annotations
    - Changed comparison of String results in for comprehension
    - Added logger statements
    - General formatting
    ngmjohnstone committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7a57a13 View commit details
    Browse the repository at this point in the history
  2. PODS-9123: Addressing PR comments 2

    Code:
    - Fixed scalastyle complaints
    - Removed calls to list of schemes API
    - Added logging for when call to getLegacySchemeDetails fails
    - General refactoring
    - Added test for auth actions
    ngmjohnstone committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fb7768e View commit details
    Browse the repository at this point in the history