Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements based on experience #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ran-lasgalen
Copy link

I've used your script to set up my system, and found that some errors may be easily fixed and some improvements make it more usable in different setups. So I suggest them, split in several commits so you may select what you think appropriate.

@hn
Copy link
Owner

hn commented Aug 3, 2017

Hi, thank you very much for your contribution and especially for the fine-grained commits.

I've merged most of the commits except:
339d459: I have to think about that. If we use external env variables, I would prefer a more consistant and well-considered naming scheme, e.g. TARGET_PARTBIOS, TARGET_HOSTNAME, ...
5c3111b: I haven't used autoexpand=on so far and I don't know if it's a good idea to enable it by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants