update deps #4
Open
update deps #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoichi
approved these changes
Jun 11, 2021
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| # bs-use-fetch | |||
|
|
|||
| A ReasonReact useFetch hook. It: | |||
| A React useFetch hook. It: | |||
There was a problem hiding this comment.
I think this is one place where search-and-replace didn't quite work :)
Suggested change
| A React useFetch hook. It: | |
| - A React useFetch hook. It: | |
| + A useFetch hook for reason-react. It: |
Feel free to reword :)
There was a problem hiding this comment.
Good eye. At the very least, its being used as a learning tool!
Update with a Reason/Rescript React useFetch hook figuring the current state of the ecosystem. Let me know.
Thanks again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings @hoichi.
This PR is not necessary. I was just studying your code and happened to update it. You make excellent comments and I thank you for it as a person who is learning by reading the comments.
Best to you.